Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluck/filter not working on admin table initial vals in changefeeds #5241

Closed
deontologician opened this issue Dec 29, 2015 · 5 comments
Closed
Assignees
Milestone

Comments

@deontologician
Copy link
Contributor

The query I ran is:

r.db('rethinkdb').table('table_status')
    .filter({db: 'db1'})
    .pluck('db', 'name')
    .changes({include_initial: true, squash: true, include_states: true})

The initial values I get back ignore the filter (I get dbs other than 'db1'), and it does not do the pluck, I get the full document back. Once actual changes happen, the filter and pluck are respected.

I tried this on a normal table and it worked fine. I'm assuming other transformations have the same problem but I haven't checked that.

ping @mlucy: I remember us running across something like this before about changefeeds on admin tables being funky, but I can't find another issue about it. I found this issue initially in the ruby driver, but verified it in the data explorer

@mlucy mlucy added this to the 2.2.x milestone Dec 29, 2015
@mlucy
Copy link
Member

mlucy commented Dec 29, 2015

@deontologician -- just to check, this is only on artificial tables?

@deontologician
Copy link
Contributor Author

Right, it worked fine on a normal table

deontologician pushed a commit to rethinkdb/logstash-input-rethinkdb that referenced this issue Dec 29, 2015
@danielmewes danielmewes modified the milestones: 2.3-polish, 2.2.x Jan 7, 2016
@mlucy mlucy self-assigned this Jan 8, 2016
@mlucy mlucy modified the milestones: 2.2.x, 2.3-polish Jan 8, 2016
@mlucy mlucy added the st:review label Jan 8, 2016
@mlucy
Copy link
Member

mlucy commented Jan 8, 2016

This is in CR 3414 by @danielmewes . I fixed a problem with the state documents on artificial include_initial streams with no initial values while I was in there. I think we should ship this in a point release since it seems like a clear bug.

@danielmewes
Copy link
Member

Yep I just moved it into 2.3-polish since it didn't seem critical, but since you have a fix now we should definitely backport it.

@mlucy
Copy link
Member

mlucy commented Jan 16, 2016

This is in next and 2.2.x.

@mlucy mlucy closed this as completed Jan 16, 2016
@danielmewes danielmewes modified the milestones: 2.2.x, 2.2.4 Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants