Git sync APIs #7364
Git sync APIs #7364
Conversation
cli/pkg/gitutil/gitcmdwrapper.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| // TODO : handle detached state |
There was a problem hiding this comment.
Does that need to be handled now?
There was a problem hiding this comment.
Ideally not. Unless the user makes some git operations externally. I will throw an error.
| // To execute git operations we use the go-git library. | ||
| // However the library does not support all git operations and in those cases we directly run git commands. | ||
| // The utility functions in this file directly run git commands. | ||
| package gitutil |
There was a problem hiding this comment.
It'd be great with some tests in this package. Maybe there's a testcontainer that launches a Git server?
There was a problem hiding this comment.
Yeah I added an issue to handle this later : https://github.com/rilldata/rill-private-issues/issues/1825
cli/pkg/local/git.go
Outdated
| // Get authenticated admin client | ||
| if !s.app.ch.IsAuthenticated() { | ||
| return errors.New("must authenticate before performing this action") | ||
| } |
There was a problem hiding this comment.
Why? I think the expectation is that we can still check status, push and pull if you run rill start in a self-managed Git.
There was a problem hiding this comment.
We won't be able to fetch the git credentials from the admin service right ? Or am I missing something.
closes https://github.com/rilldata/rill-private-issues/issues/1743
Checklist: