Skip to content

Autocomplete and invite in Share Project Popover #7393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented May 31, 2025

Fixes ENG-732

This pull request introduces the functionality to search for and invite both emails and groups within the Share Project Popover.

CleanShot.2025-06-03.at.16.33.37.mp4

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericokuma
Copy link
Contributor

ericokuma commented Jun 2, 2025

Looks good!

Some feedback:

  • When typing an email or group, can we maintain the tab to create email pill?
  • Highlight the search box when it's active. See what's in production today:
Screenshot 2025-06-02 at 9 27 34 AM
  • Maintain the same font size as what's in production:
Screenshot 2025-06-02 at 9 28 34 AM vs Screenshot 2025-06-02 at 9 28 46 AM
  • In the dropdown, display avatar for each item (also, if a member is a guest, display the guest pil)
  • Make sure that the dropdown box width matches the width of the search box

@lovincyrus
Copy link
Contributor Author

lovincyrus commented Jun 2, 2025

Looks good!

Some feedback:

  1. When typing an email or group, can we maintain the tab to create email pill?
  2. Highlight the search box when it's active. See what's in production today:
Screenshot 2025-06-02 at 9 27 34 AM 3. Maintain the same font size as what's in production:

Screenshot 2025-06-02 at 9 28 34 AM vs Screenshot 2025-06-02 at 9 28 46 AM
4. In the dropdown, display avatar for each item (also, if a member is a guest, display the guest pil)
5. Make sure that the dropdown box width matches the width of the search box

fyi: This PR is still in draft.

@lovincyrus lovincyrus self-assigned this Jun 2, 2025
@lovincyrus
Copy link
Contributor Author

Latest demo:

CleanShot.2025-06-03.at.16.33.37.mp4

@lovincyrus lovincyrus marked this pull request as ready for review June 3, 2025 23:38
@lovincyrus lovincyrus requested a review from ericokuma June 3, 2025 23:38
@lovincyrus
Copy link
Contributor Author

This is ready for UXQA review @ericokuma

Copy link
Contributor

ericokuma commented Jun 4, 2025

Looks great!
Some feedback:

Screenshot 2025-06-03 at 5.07.38 PM.png

  • Update placeholder text to say: "Search users, groups, or add emails, separated by commas"

  • When there are more than 1 row of pills, the dropdown doesn't move along with the bottom edge of the search field

    my-rill-project overview - Rill - 3 June 2025

Copy link
Contributor

@ericokuma ericokuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@lovincyrus lovincyrus requested a review from ericokuma June 4, 2025 00:47
@lovincyrus
Copy link
Contributor Author

This is ready for code review @ericpgreen2

@lovincyrus lovincyrus requested a review from ericpgreen2 June 4, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants