-
Notifications
You must be signed in to change notification settings - Fork 134
Autocomplete and invite in Share Project Popover #7393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Latest demo: CleanShot.2025-06-03.at.16.33.37.mp4 |
This is ready for UXQA review @ericokuma |
Looks great!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
This is ready for code review @ericpgreen2 |
3adf7f9
to
7d9985d
Compare
Ah dang…I guess the placeholder text is now too long with the font size change. Sorry to do this but let's revert back to what you had before otherwise LGTM! @jkhwu? |
my-rill-project overview - Rill - 4 June 2025
|
@jkhwu UXQA:
|
Update: Found it |
Addressed the feedback above @ericokuma |
From @jkhwu, the last item is that the "invite" button should be enabled once a user starts typing something into the search: in this PR: Otherwise, LGTM!! |
We shouldn't do that. The invite button should only be available when a chip/pill is created from the users' input. We want to avoid submitting users' jibberish texts. |
While that's true, you could enter an actual email: janet.hwu@rilldata.com but if you didn't press the tab, comma, or space key, the invite button remains disabled. So it looks like it's broken |
Ok, resolved! |
hmmm, the UX is not quite right. Could you reference what you've already built in production?
|
Fixes ENG-732
This pull request introduces the functionality to search for and invite both emails and groups within the Share Project Popover.
CleanShot.2025-06-03.at.16.33.37.mp4
Checklist: