Skip to content

Autocomplete and invite in Share Project Popover #7393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 68 commits into
base: main
Choose a base branch
from

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented May 31, 2025

Fixes ENG-732

This pull request introduces the functionality to search for and invite both emails and groups within the Share Project Popover.

CleanShot.2025-06-03.at.16.33.37.mp4

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericokuma
Copy link
Contributor

ericokuma commented Jun 2, 2025

Looks good!

Some feedback:

  • When typing an email or group, can we maintain the tab to create email pill?
  • Highlight the search box when it's active. See what's in production today:
Screenshot 2025-06-02 at 9 27 34 AM
  • Maintain the same font size as what's in production:
Screenshot 2025-06-02 at 9 28 34 AM vs Screenshot 2025-06-02 at 9 28 46 AM
  • In the dropdown, display avatar for each item (also, if a member is a guest, display the guest pil)
  • Make sure that the dropdown box width matches the width of the search box

@lovincyrus
Copy link
Contributor Author

lovincyrus commented Jun 2, 2025

Looks good!

Some feedback:

  1. When typing an email or group, can we maintain the tab to create email pill?
  2. Highlight the search box when it's active. See what's in production today:
Screenshot 2025-06-02 at 9 27 34 AM 3. Maintain the same font size as what's in production:

Screenshot 2025-06-02 at 9 28 34 AM vs Screenshot 2025-06-02 at 9 28 46 AM
4. In the dropdown, display avatar for each item (also, if a member is a guest, display the guest pil)
5. Make sure that the dropdown box width matches the width of the search box

fyi: This PR is still in draft.

@lovincyrus lovincyrus self-assigned this Jun 2, 2025
@lovincyrus lovincyrus changed the title [ENG-732] Autocomplete and invite in Share Project Popover Autocomplete and invite in Share Project Popover Jun 3, 2025
@lovincyrus
Copy link
Contributor Author

Latest demo:

CleanShot.2025-06-03.at.16.33.37.mp4

@lovincyrus lovincyrus marked this pull request as ready for review June 3, 2025 23:38
@lovincyrus lovincyrus requested a review from ericokuma June 3, 2025 23:38
@lovincyrus
Copy link
Contributor Author

This is ready for UXQA review @ericokuma

Copy link
Contributor

ericokuma commented Jun 4, 2025

Looks great!
Some feedback:

Screenshot 2025-06-03 at 5.07.38 PM.png

  • Update placeholder text to say: "Search users, groups, or add emails, separated by commas"

  • When there are more than 1 row of pills, the dropdown doesn't move along with the bottom edge of the search field

    my-rill-project overview - Rill - 3 June 2025

Copy link
Contributor

@ericokuma ericokuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@lovincyrus
Copy link
Contributor Author

This is ready for code review @ericpgreen2

@lovincyrus lovincyrus requested a review from ericpgreen2 June 4, 2025 00:57
@lovincyrus lovincyrus force-pushed the cyrus/autocomplete-n-invite branch from 3adf7f9 to 7d9985d Compare June 4, 2025 17:47
Copy link
Contributor

Ah dang…I guess the placeholder text is now too long with the font size change. Sorry to do this but let's revert back to what you had before

Screenshot 2025-06-04 at 11.27.47 AM.png

otherwise LGTM! @jkhwu?

Copy link
Contributor

ericokuma commented Jun 4, 2025

  • I guess another thing I noticed is the search field height up larger than the invite button.

    Here's what it looked like before:

Screenshot 2025-06-04 at 12.02.24 PM.png

  • And another thing I noticed is when the search field is blank, the role selector shouldn't be there:

Screenshot 2025-06-04 at 12.03.47 PM.png

Copy link
Contributor

Copy link
Contributor

NIT: Admin role isn't right-aligned with the other roles

Screenshot 2025-06-04 at 6.06.02 PM.png

Copy link
Contributor

ericokuma commented Jun 5, 2025

my-rill-project overview - Rill - 4 June 2025

  • Actually, General Access area should be fixed and everything scrolls underneath it. That might solve this

Copy link
Contributor

ericokuma commented Jun 5, 2025

@jkhwu UXQA:

  • There should be hover states for the following:
    • Link to docs
    • Dropdown selector for the general access (invite only or everyone at) selector

@lovincyrus
Copy link
Contributor Author

NIT: Admin role isn't right-aligned with the other roles

Screenshot 2025-06-04 at 6.06.02 PM.png

How do I replicate that? Here's what I'm seeing:

CleanShot 2025-06-05 at 10 04 41@2x

@lovincyrus
Copy link
Contributor Author

lovincyrus commented Jun 5, 2025

  • Dropdown selector for the general access (invite only or everyone at) selector

What is the hover state for this? Can you link it or provide a screenshot?

Update: Found it

@lovincyrus
Copy link
Contributor Author

Addressed the feedback above @ericokuma

Copy link
Contributor

From @jkhwu, the last item is that the "invite" button should be enabled once a user starts typing something into the search:

in Prod:

Screenshot 2025-06-05 at 11.53.31 AM.png

in this PR:

Screenshot 2025-06-05 at 11.53.47 AM.png

Otherwise, LGTM!!

@lovincyrus
Copy link
Contributor Author

From @jkhwu, the last item is that the "invite" button should be enabled once a user starts typing something into the search:in Prod:

Screenshot 2025-06-05 at 11.53.31 AM.png

in this PR:

Screenshot 2025-06-05 at 11.53.47 AM.png

We shouldn't do that. The invite button should only be available when a chip/pill is created from the users' input. We want to avoid submitting users' jibberish texts.

Copy link
Contributor

ericokuma commented Jun 5, 2025

While that's true, you could enter an actual email: janet.hwu@rilldata.com but if you didn't press the tab, comma, or space key, the invite button remains disabled. So it looks like it's broken

@lovincyrus
Copy link
Contributor Author

While that's true, you could enter an actual email: janet.hwu@rilldata.com but if you didn't press the tab, comma, or space key, the invite button remains disabled. So it looks like it's broken

Ok, resolved!

Copy link
Contributor

hmmm, the UX is not quite right. Could you reference what you've already built in production?

  1. Hitting invite triggers a loading state in the invite button
  2. Hitting invite doesn't first convert the string into pill
  3. Interestingly, there's some complex logic you built previously with regards to non-pill strings and the enablement/disablement of the invite button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants