Skip to content

Connectors (sources) and OLAP under Connect from References, [Added a lot more example and content to Reference -> Connector YAML] #7652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Aug 8, 2025

Conversation

royendo
Copy link
Contributor

@royendo royendo commented Jul 18, 2025

Moving Connector and OLAP to Docs under CONNECT

WIth a lot more UI friendly design! Still working on the actual content
Screenshot 2025-07-17 at 22 17 43

Screenshot 2025-07-17 at 22 24 56

Which means no more duplicate source and olap docs,
Reference (as is explained in the other doc is strictly for YAML parameters and not explanations.

Docs are more wordy and explanatory of what we can connect to as a concept.

Still a bit of work to do but want to open the Draft PR if anyone interested in seeing designs :)

@royendo royendo requested a review from ericpgreen2 July 18, 2025 04:34
royendo added 2 commits July 17, 2025 23:13
connect/connect/
to connect/sources/

not sure why i exploded in broken links (more than sources, possibly we werent checking certain folders but all green now)
@royendo
Copy link
Contributor Author

royendo commented Jul 18, 2025

notes for tomorrow connect/source/connectors to connect/connector/sources
makes more sense

write out MotherDuck Doc, and Templating Sources

make sure that the links and images are actually working!

@royendo royendo marked this pull request as ready for review July 18, 2025 19:45
@royendo
Copy link
Contributor Author

royendo commented Jul 18, 2025

opening this PR up, let me know your thoughts,

at some point i mixed up branches and had to pull the other changes to this one so need to recheck once we merge my other two PRs.

This moves a lot of docs around but i ran a custom playwright check for links and returned green for links, but will need to do a final run 👍

@royendo royendo changed the title [Preview] Connects and OLAP under Connect from References, [Added a lot more example and content to Reference -> Connector YAML] Jul 21, 2025
@royendo royendo changed the title Connects and OLAP under Connect from References, [Added a lot more example and content to Reference -> Connector YAML] Connectors (sources) and OLAP under Connect from References, [Added a lot more example and content to Reference -> Connector YAML] Jul 21, 2025
@royendo royendo mentioned this pull request Jul 21, 2025
8 tasks
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we remove a layer of hierarchy here so the list of connectors is 2-layers down, not 3-layers down?
    image
  2. Can we sort the connectors alphabetically? (Helps for scanning a list for what you're looking for.)
  3. Optionally, we could have a directory for each "kind" of data source: "Object storage", "Data warehouses", "Databases", "OLAP engines", "Other"
  4. Should this section be all about connecting data, and we move the Slack connector to the "Integrate" section?
  5. Can we have either content or a redirect at docs.rilldata.com/connect:
    image
  6. Whichever approach we take for item 5, can we, near the very top, describe the different connection strategies (e.g. embedded OLAP + ingest your own data, BYO OLAP, BYO OLAP w/ "native" connectors, etc.)
  7. These YAML reference links did not take me to the connector-specific section:
    image

@royendo
Copy link
Contributor Author

royendo commented Jul 21, 2025

  1. Can we remove a layer of hierarchy here so the list of connectors is 2-layers down, not 3-layers down?

Done
Screenshot 2025-07-21 at 15 33 03

  1. Can we sort the connectors alphabetically? (Helps for scanning a list for what you're looking for.)

Done (above)

  1. Optionally, we could have a directory for each "kind" of data source: "Object storage", "Data warehouses", "Databases", "OLAP engines", "Other"

I think flat is okay for now :)

  1. Should this section be all about connecting data, and we move the Slack connector to the "Integrate" section?

It originally lived under Explore/alert/slack kind of hidden so wanted to show that it was a connector but yeah kind of out of place here.

  1. Can we have either content or a redirect at docs.rilldata.com/connect:
    Fixed with 1.
  1. Whichever approach we take for item 5, can we, near the very top, describe the different connection strategies (e.g. embedded OLAP + ingest your own data, BYO OLAP, BYO OLAP w/ "native" connectors, etc.)

Will add this tidbit of data!

  1. These YAML reference links did not take me to the connector-specific section:

Looking into this why the #... isn't working.

royendo added 2 commits July 29, 2025 11:42
Kept the tip on motherduck on this page just in case users are directed here.
@royendo royendo mentioned this pull request Jul 29, 2025
8 tasks
@royendo
Copy link
Contributor Author

royendo commented Jul 31, 2025

Removed Templating from Deploy and moved to Connect!

There's a bit more content that I will add in a following PR but wanted to get this one out of door., as its already pretty big.

Follow ups are:

  • Menu Splash Pages #7692 - Splash pages
  • Redirect checker (discussed with Nishant)
  • Content Overview (IE: rework the deploy dashboard contents, focus on UI first)
  • Media update (Out of date screenshots and ugly GIFs (made by me )
  • Additional Guides

@royendo royendo requested a review from ericpgreen2 July 31, 2025 19:08
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Aesthetically, I had a hard time recognizing which description applied to which connection strategy. It'd help if the description were more "coupled" with the strategy name– the description could be indented at the same level as the bullet point, or the description could even be included in the main bullet point.
    image
  2. There's something not clear about the distinction between BYO OLAP and BYO OLAP w/ Native Connectors. What about just two categories: Rill-managed OLAP (where options are DuckDB or ClickHouse, depending on scale) and BYO OLAP (where some engines support modeling in the native SQL dialect, some don't).
  3. There's a lack of parallelism between the /connect, /connect/data-sources (which doesn't exist :)), and /connect/olap pages. I'd expect we have a /connect/data-sources page that matches the /connect/olap page, including the connector tiles.

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. With these callouts at a different level-of-indentation as the connection strategies, it's hard to read. Can they be at the same level-of-indentation (to better couple them with the associated strategy), or can we communicate the info in a different way or place?
    image
  2. It's not consistent that, on the /connect page, the sequence is 1. OLAP Engines 2. Data sources; but in the sidebar, the sequence is 1. Data sources 2. OLAP Engines. Let's pick one sequence and be consistent with it. I'm thinking that maybe we should frame this as sequential decisions to make: first decision is which OLAP engine do you want to use; second decision is which data do you want to orchestrate into your OLAP engine.

- **Dashboards** - Visualize your data with interactive charts and tables

:::warning OLAP Engine Limitations
Rill supports connecting your data to both [DuckDB](/connect/olap/duckdb) and [ClickHouse](/connect/olap/clickhouse). However, there are still some features in development for managed ClickHouse. [Contact our team](/contact) for more informaton and scheduled feature releases!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious how this comment "However, there are still some features in development for managed ClickHouse" relates to this page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should be a dedicated section to describe how different SQL is needed depending on your OLAP engine (DuckDB or ClickHouse)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, unfortunately its not as simple as just the SQL, we dont support all the source ingestions into CH at this moment...

im wondering if adding a little icon on the button indicating duck/ch support...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a small snippet to CH doc on managed clickhouse, and added some missing reminders, depending on how a user might stumble on to our docs

@royendo
Copy link
Contributor Author

royendo commented Aug 5, 2025

  1. TIL you can do indented tips.

  2. an interesting convo to have with product to decide what the best use case of the product is. Last we decided was this
    https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7/RILL-Latest?node-id=19220-1044411&t=bG29z95XAvoAxWDq-1

seems to match. OLAP then Data

royendo added 3 commits August 5, 2025 08:59
additions to CH docs,
moved source refresh to build/models
added additional button on connect to contact for not listed olap, could be a tip though
@royendo royendo requested a review from ericpgreen2 August 5, 2025 23:33
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a few last comments!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checking that this edit was intentional? This component is used in the "Add Data" modal and now looks like this:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely not, will fix

@royendo royendo merged commit 97e39be into main Aug 8, 2025
11 checks passed
@royendo royendo deleted the docs-connectors-to-docs branch August 8, 2025 14:43
royendo added a commit that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants