Skip to content

Create YAML model files #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 7, 2025
Merged

Create YAML model files #7716

merged 34 commits into from
Aug 7, 2025

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Aug 1, 2025

This PR implements a new feature to create YAML model files from connector tables. It adds a menu item to the table context menu that allows users to generate YAML-based models for non-OLAP connectors like Postgres, MySQL, etc. Fixes https://linear.app/rilldata/issue/ENG-856/add-a-create-model-menu-item-for-connector-files, https://linear.app/rilldata/issue/ENG-860/humanize-redshift-error-when-output-location-and-role-arn-are-missing

To test

  • Postgres (use sufficientlyQualifiedTableName)
  • Athena (use sufficientlyQualifiedTableName)
  • Snowflake (use sufficientlyQualifiedTableName)
  • MySQL (use sufficientlyQualifiedTableName)
  • Redshift reference
CleanShot.2025-08-01.at.11.29.15.mp4

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Aug 1, 2025
@lovincyrus
Copy link
Contributor Author

lovincyrus commented Aug 1, 2025

Demo with dev limit

CleanShot.2025-08-01.at.13.34.32.mp4

@lovincyrus
Copy link
Contributor Author

lovincyrus commented Aug 1, 2025

Verified that we can create YAML model files for various non-OLAP connectors except for redshift. Logged a ticket here

@lovincyrus lovincyrus force-pushed the cyrus/create-model-menu-item branch from 9679a59 to 2944ec6 Compare August 4, 2025 17:51
@lovincyrus lovincyrus marked this pull request as ready for review August 4, 2025 19:27
@ericpgreen2 ericpgreen2 self-requested a review August 4, 2025 19:49
@lovincyrus
Copy link
Contributor Author

lovincyrus commented Aug 4, 2025

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clean! Left a few comments.

@lovincyrus lovincyrus requested a review from ericpgreen2 August 5, 2025 19:25
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lovincyrus lovincyrus merged commit 59bf0e1 into main Aug 7, 2025
13 checks passed
@lovincyrus lovincyrus deleted the cyrus/create-model-menu-item branch August 7, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants