Skip to content

refactor: Use dashboard refresh dates from runtime state directly #7731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

refactor: Use dashboard refresh dates from runtime state directly #7731

merged 2 commits into from
Aug 6, 2025

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Aug 5, 2025 •
edited
Loading

Given #7443, the runtime now provides a handy data_refreshed_date property on Explores, Canvases, and Components. This PR removes a long-standing hack to compute this property client-side. Now, the frontend uses the runtime's property directly.

This fixes this issue reported in Slack.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericpgreen2 ericpgreen2 self-assigned this Aug 5, 2025
@ericpgreen2 ericpgreen2 requested a review from AdityaHegde August 5, 2025 15:04
@ericpgreen2 ericpgreen2 marked this pull request as ready for review August 5, 2025 18:42
AdityaHegde
AdityaHegde approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanups!

@ericpgreen2 ericpgreen2 merged commit b5b6f9b into main Aug 6, 2025
10 checks passed
@ericpgreen2 ericpgreen2 deleted the use-last-refresh-date-from-runtime branch August 6, 2025 13:15
ericpgreen2 added a commit that referenced this pull request Aug 6, 2025
@ericpgreen2
refactor: Use dashboard refresh dates from runtime state directly (#7731
0d92d6c 
)

* refactor: Use dashboard refresh dates from runtime state directly

* Consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaHegde AdityaHegde AdityaHegde approved these changes

Assignees

@ericpgreen2 ericpgreen2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpgreen2 @AdityaHegde