fix: rename grain to duration in annotations #7736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindspank
reviewed
Aug 6, 2025
| @@ -15,7 +15,7 @@ rill project connect-github [<path>] [flags] | |||
| ``` | |||
| --path string Path to project repository (default: current directory) (default ".") | |||
| --subpath string Relative path to project in the repository (for monorepos) | |||
| --remote string Remote name (default: first Git remote) | |||
| --remote string Remote name (default: origin) (default "origin") | |||
There was a problem hiding this comment.
Unrelated? Seems fine though
There was a problem hiding this comment.
Looks like make docs.generate was missed when this change was made. So when I ran it here these were changed as well.
mindspank
approved these changes
Aug 6, 2025
AdityaHegde
added a commit
that referenced
this pull request
Aug 6, 2025
* fix: rename grain to duration in annotations * Update validation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a requirement change we are renaming
graincolumn todurationcolumn in annotation source table.Checklist: