Skip to content

Fix panic when parsing a YAML file with an empty environment override #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fix panic when parsing a YAML file with an empty environment override #7737

merged 1 commit into from
Aug 6, 2025

Conversation

begelundmuller
Copy link
Contributor

Fixes a bug that arises when an environment override is empty, e.g.:

type: model
sql: SELECT 1
dev:

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Aug 6, 2025
@begelundmuller begelundmuller requested a review from k-anshul August 6, 2025 10:23
@begelundmuller begelundmuller merged commit 591b68e into main Aug 6, 2025
15 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-panic-parse-null-env-override branch August 6, 2025 10:40
begelundmuller added a commit that referenced this pull request Aug 6, 2025
@begelundmuller
Fix panic when parsing a YAML file with an empty environment override (…
b5eb575 
…#7737)
begelundmuller added a commit that referenced this pull request Aug 6, 2025
@begelundmuller
Fix panic when parsing a YAML file with an empty environment override (…
a2578cf 
…#7737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-anshul k-anshul k-anshul approved these changes

Assignees

@begelundmuller begelundmuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@begelundmuller @k-anshul