Skip to content

fix: Disable comparison with rill time in alerts and reports #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

fix: Disable comparison with rill time in alerts and reports #7745

merged 1 commit into from
Aug 11, 2025
+40 −19

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Aug 7, 2025 •
edited
Loading

We cant really do correct comparison without some additional rill time syntax support. So temporarily disabling comparisons in alerts an reports.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde added the blocker A release blocker issue that should be resolved before a new release label Aug 8, 2025
@briangregoryholmes
Copy link
Contributor

What do we think the ETA is for re-enabling this?

@AdityaHegde
Copy link
Collaborator Author

Hmmm we would need to add support for offset 2M like support in syntax. Not too much effort, could be squeezed in for next release, not tomorrow's release though.

@AdityaHegde AdityaHegde merged commit f3ed3a9 into main Aug 11, 2025
15 checks passed
@AdityaHegde AdityaHegde deleted the fix/rill-time-comparison-alerts-reports branch August 11, 2025 15:00
AdityaHegde added a commit that referenced this pull request Aug 11, 2025
@AdityaHegde
Fix rill time with alerts and reports (#7745)
009d6df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangregoryholmes briangregoryholmes briangregoryholmes approved these changes

Assignees
No one assigned
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @briangregoryholmes