Skip to content

fix: selecting all on a high cardinality dimension in dimension filter drop down crashes the app #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Aug 8, 2025

In dimension filter dropdown, select all does it one at a time. This leads to gzip calculation to happen one at a time. With a large set of values this slows down and crashes the app.

Moveing to using a multi select method so that all the values are toggled at once.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from djbarnwal August 8, 2025 12:39
@AdityaHegde AdityaHegde assigned mindspank and unassigned mindspank Aug 8, 2025
@AdityaHegde AdityaHegde requested a review from mindspank August 8, 2025 12:39
@AdityaHegde AdityaHegde merged commit 3fb9206 into main Aug 8, 2025
15 checks passed
@AdityaHegde AdityaHegde deleted the fix/toggle-multiple-dimeison-values-at-once branch August 8, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants