Skip to content

Apply security policies in ResolveCanvas #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Aug 8, 2025

Apply the same security policy checks in ResolveCanvas as we do in GetResource. Without this, the ResolveCanvas returns metadata about metrics views and dimensions/measures that will fail when queried for the current user.

Closes https://linear.app/rilldata/issue/PLAT-164/sec-policy-exclude-not-working-on-canvas

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller marked this pull request as ready for review August 8, 2025 15:00
@begelundmuller begelundmuller requested a review from pjain1 August 8, 2025 15:00
@begelundmuller begelundmuller self-assigned this Aug 8, 2025
@begelundmuller begelundmuller merged commit 6786a12 into main Aug 12, 2025
15 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/resolve-canvas-security-policies branch August 12, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants