Skip to content

Fix: unnecessary annotations API call when metrics view has no annotations defined #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

Fix: unnecessary annotations API call when metrics view has no annotations defined #7759

merged 1 commit into from
Aug 11, 2025

Conversation

AdityaHegde
Copy link
Collaborator

We are making a call for annotations even when we know for sure the metrics view has no annotations defined.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from djbarnwal August 11, 2025 11:42
@AdityaHegde AdityaHegde changed the title Fix: unnecessary annotations API when metrics view has no annotations defined Fix: unnecessary annotations API call when metrics view has no annotations defined Aug 11, 2025
@AdityaHegde AdityaHegde merged commit 106eb1e into main Aug 11, 2025
15 checks passed
@AdityaHegde AdityaHegde deleted the fix/unnessary-annotations-api branch August 11, 2025 15:01
AdityaHegde added a commit that referenced this pull request Aug 11, 2025
@AdityaHegde
Fix: unnessary annotations API when metrics view has none (#7759)
22953a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbarnwal djbarnwal djbarnwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @djbarnwal