Skip to content

triggers: implement tcontrol #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

YenHaoChen
Copy link
Collaborator

@YenHaoChen YenHaoChen commented Jun 11, 2024

Implement Debug spec Section 5.7.6. Trigger Control (tcontrol). This commit lets tcontrol be read-only 0 if the number of triggers is 0.

The spec says the optional tcontrol is useful only if medeleg[3] (breakpoint) is read-only 0. Please note that Spike lets the medeleg[3] be read-write.
image

Implement Debug spec Section 5.7.6. Trigger Control (tcontrol).

This commit lets tcontrol be read-only 0 if number of triggers is 0.
Copy link
Contributor

@rtwfroody rtwfroody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Thanks for implementing this so quickly.

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. (And thanks @rtwfroody for the review)

@aswaterman aswaterman merged commit 9bcda41 into riscv-software-src:master Jun 11, 2024
3 checks passed
@YenHaoChen YenHaoChen deleted the pr-tcontrol branch June 13, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants