-
Notifications
You must be signed in to change notification settings - Fork 925
exposing riscv and softfloat as libraries #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
exposing riscv and softfloat as libraries #1968
Conversation
Hang on, softfloat should be installed through softfloat, right? |
I think we will have to learn from other users whether this causes annoyance, namely as a result of overwriting |
OK, since @jerryz123 and I had similar reactions, let's hold off on this one. |
installing libsoftfloat might be a bad idea
Also this change wasn't necessary for my flow to link with libriscv at the installed path. I'll need to check how this works |
Spike's softfloat has its own augmentations, so we should avoid naming it the same as public softfloat. We might want to namespace both of these libraries (e.g. Furthermore, I'm not sure that |
As it turns out, the Softfloat repo provides no flow for installing libsoftfloat and its headers... only this repo does. Given that, I don't think there's any risk from installing libsoftfloat.a. This repo already installs all the softfloat headers, and the .so as well. Installing libriscv.a in addition to libriscv.so is also acceptable. If someone were to untangle this mess properly, I think they should:
I don't expect ^ to get done anytime soon, so this PR should be good as it stands. @mslijepc , you have a use case which requires the static libraries to be installed instead of the dynamic libs? |
@jerryz123 Here is a demo project which I made for our usecase (using Spike as a library) https://github.com/sifive/riscv-isa-sim-lib-demo |
this PR will make
riscv
andsoftfloat
exposed and easily linked in case we want to linkriscv-isa-sim
with some other simulation environment.