forked from php/php-src
-
Notifications
You must be signed in to change notification settings - Fork 2
merge #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
merge #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-7.3: Fixed bug #77329 (Buffer Overflow via overly long Error Messages)
* PHP-7.4: Fixed bug #77329 (Buffer Overflow via overly long Error Messages)
This variable was dropped in the pkg-config migration, which resulted in spurious warnings about using valgrind with external PCRE. Fix the checks to use the right variable.
I'm counting this towards the non-string needle deprecation from https://wiki.php.net/rfc/deprecations_php_7_3. I wasn't aware that mb_ereg_replace() is also affected by this issue. It's even more ridiculous than usual here, because the integer is interpreted as an ASCII codepoint, even though these are supposed to be multibyte functions :(
Instead of manually handling the string conversion, use the standard zpp mechanism.
This is logically an integer, and the function also returns the old value as an integer. The fact that the integer needs to be converted to a string for the ini assignment is an implementation detail.
Due to a typo, this code used to check for array_merge_recursive twice.
* PHP-7.2: Properly check for array_replace_recursive in sccp.c
* PHP-7.3: Properly check for array_replace_recursive in sccp.c
* PHP-7.4: Properly check for array_replace_recursive in sccp.c
* PHP-7.3: [ci skip] Add missing notes regarding gc_status()
* PHP-7.4: [ci skip] Add missing notes regarding gc_status()
This patch removes the so called local variables defined per file basis for certain editors to properly show tab width, and similar settings. These are mainly used by Vim and Emacs editors yet with recent changes the once working definitions don't work anymore in Vim without custom plugins or additional configuration. Neither are these settings synced across the PHP code base. A simpler and better approach is EditorConfig and fixing code using some code style fixing tools in the future instead. This patch also removes the so called modelines for Vim. Modelines allow Vim editor specifically to set some editor configuration such as syntax highlighting, indentation style and tab width to be set in the first line or the last 5 lines per file basis. Since the php test files have syntax highlighting already set in most editors properly and EditorConfig takes care of the indentation settings, this patch removes these as well for the Vim 6.0 and newer versions. With the removal of local variables for certain editors such as Emacs and Vim, the footer is also probably not needed anymore when creating extensions using ext_skel.php script. Additionally, Vim modelines for setting php syntax and some editor settings has been removed from some *.phpt files. All these are mostly not relevant for phpt files neither work properly in the middle of the file.
* PHP-7.4: Remove local variables
Instead of having custom parameter handling.
…g* insted of zval(s).
* PHP-7.4: Reset common fields of EG(trampoline)
… as deprecated These functions have serious limitations and may confuse users. Same operations can be done using the new ldap control system in search operations.
* PHP-7.4: Mark ldap_control_paged_result and ldap_control_paged_result_response as deprecated
ldap_sort was deprecated in PHP7, it is now removed. This allows removing the LDAP_DEPRECATED flag when building against openldap.
* PHP-7.4: Remove copyright years.
Noticed these while implementing error handler changes.
I'm removing the argument entirely here, but we might want to change this to passing null or and empty array instead, if the impact of dropping it entirely turns out to be too large. This was deprecated as part of https://wiki.php.net/rfc/deprecations_php_7_2 as a doc-only deprecation.
* PHP-7.3: Fix NEWS
* PHP-7.4: Fix NEWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.