Skip to content

Raise minimum required Selenium version to 3.14 to ease support for Selenium 4 #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaltat opened this issue Oct 20, 2019 · 0 comments · Fixed by #1495
Closed

Raise minimum required Selenium version to 3.14 to ease support for Selenium 4 #1493

aaltat opened this issue Oct 20, 2019 · 0 comments · Fixed by #1495

Comments

@aaltat
Copy link
Contributor

aaltat commented Oct 20, 2019

Based Selenium 4.0.0 Alpha 3, many of the Selenium 3 deprecated methods have been removed. This change in the Selenium side, causes problems for the Open Browser keyword and keywords fails. We could workaround the problem by creating more code to detect Selenium version and create some code to call Selenium in proper way in proper version, but we already have quite lot of code for that in the WebDriverCreator class. That code is already quite complex and causes quite many bugs. Therefore I think it will be easier to raise the minimum required Selenium version to 3.14 (most likely to the latest in Selenium 3 series). This change has several advantages.

  1. This cleans the WebDriverCreator class code quite nicely and makes it easier to read.
  2. Support for Selenium 4 is easier after the requiring Selenium 3.14, most likely no changes are required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant