Return screenshot as base64 string and embed into log #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated unit test to look for a tuple - Fixed issue with code on return statement - Fixed issue with unit tests
Forgot to add in the setting of the screenshot directory to handle BASE64 when not in all caps.
There is a still an error when the library is initialized with something like `bASe64`. It is not setting it. From the code this looks like the unintended behavior. But then I don't understand why theother test case works when `EmBed` is given. This too should fail as per my reading of the code. Going to trace through a bit more to see why that isn't failing and what I may be missing.
aaltat
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly modified version of #1923 which instead of modifying the EMBED functionality currently implemented, it allows for returning the base64 tring is one uses BASE64 instead. The reason for providing this alternative method is to prevent signifigant increase in filesize for the current users whom might not need the returned string.