Latest versions jun2025 #1944
Merged
Latest versions jun2025 #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reveted back from expressive matrix options as I need to learn how to use key-value pairs within gh actions.
Also reduce test matrix for now and set setup-chrome action to v1 (as compared to @latest)
Looks like the system has Chrome 1.37 already installed. This will setup chrome 137 somewhere but more importantly add the driver. Realizing I may need to rework how we setup the machine ..
…oss many versions
aaltat
reviewed
Aug 3, 2025
| @@ -43,6 +43,7 @@ Handle Alert returns message | |||
|
|
|||
| Handle Alert with custom timeout | |||
| Click Button Slow alert | |||
| Sleep 0.1s | |||
There was a problem hiding this comment.
Doesn’t this indicate problem in the library, instead of doing sleep, should library be fixed?
There was a problem hiding this comment.
Updated this. I removed the sleep but also extended the given timeout. For this test the alert was delayed 500ms and it appears that timing out at 1sec (or 500ms later) is too short to reasonable expect for alert triggered and then detected. This extension gives it a reasonable amount of time after triggering.
Previously the timeout was 1 sec and the alert was delayed 500ms. With a normal execution it seems that that 500ms diference is just not long enough to reasonably expect the alert to appear. In reviewing this test it was shown any delay was useful and the needed time for an alert to triggered and then recognized would need more than 500ms.
aaltat
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanup work on the internal test suite and bringing up the versions of parts of the tech stack.