Skip to content

Prepare for 1.7.2 release #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2015
Merged

Prepare for 1.7.2 release #457

merged 3 commits into from
Jul 22, 2015

Conversation

zephraph
Copy link
Member

No description provided.

@zephraph
Copy link
Member Author

@emanlove, there's an issue with #450 that's causing the test to fail. I've corrected one issue that I found (which I missed in the review). I've got to go to lunch, but I'll take a fresh look at this when I get back.

After this is cleared up I'm ready to release.

@zephraph
Copy link
Member Author

Hopefully this will shore up any errors that there were and we can push out the release 🙏

@zephraph
Copy link
Member Author

Looks like we're good! I'm going ahead with the release.

@zephraph
Copy link
Member Author

... or not.

@emanlove, There are five tests failing from my machine from the Acceptance.Multiple Browsers testsuite.

I'm getting

WindowsError: [Error 145] The directory is not empty: 'c:\\users\\USER\\appdaa\\local\\temp\\tmpzvunnb.webdriver.xpi\\components'

I think this is likely because of my anti-virus though... will you run the suites and make sure everything is okay on your machine?

EDIT: I can't reproduce this on any other environment. I hate my computer.

zephraph added a commit that referenced this pull request Jul 22, 2015
@zephraph zephraph merged commit 53b6c7a into master Jul 22, 2015
@zephraph zephraph deleted the 1.7.2-release branch July 24, 2015 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant