-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Dialogs: Enhance look and feel #5334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @pekkaklarck, what do you think about the idea of switching from Tkinter to Flet (https://flet.dev/) which provides a better styling and design options ? |
I don't think it's a good idea with the version distributed with Robot. It would be fine if you'd create an external library for this purpose. |
Thanks for your feedback! Could you clarify what you mean by creating an external library for this purpose? Are you suggesting a standalone package that integrates with Robot Framework, or something else? I'd appreciate any guidance on the best approach since i would love to start contributing to the project after the wonderful experience at the Robocon 2025. |
PR #5333 implements this. |
@LucianCrainic Yes, I meant creating an external library. It could have same keywords as the standard Dialogs to make switching to it easy, but it could also get new keywords if there are needs. New keywords could then possibly be ported to Dialogs if they are generally useful and its technically feasible. |
I reviewed PR #5333 and it turned out to have various technical problems. The problems are due to the PR trying to workaround Tkinter styling limitations (e.g. styling the title native title bar isn't possible) and they seem to be way bigger than the benefits. My current thinking is that we should limit style changes to these:
My plan to go forward with this is:
|
Increase the minimun dialog size a bit to match the increased font size. Make padding and font configurable using class attributes. Also make background configurable, but leave it to the default value for now. Part of #5334.
It depends on OS how/where icons are shown. For example, on Linux with Gnone there's no icon in the dialog, but there's a taskbar icon as well as an icon in the application switcher. On Windows there's a taskbar icon and also the dialog itself has an icon. OSX is yet to be tested. This is part of #5334.
When `Get Selection From User` is used with a default value, not only select that value but also activate it. That affects moving the selection with arrow keys. Now the initial position is the selection, earlier it was the first item. To some extend related to Dialog look and feel enhancements (#5334). Too small fix to deserve its own issue.
I've done all enhancements I planned to do. The image below shows new and old dialogs on Windows, and I consider the new one better in many ways. I've also tested this on Linux and OSX and everything seems to work fine. @d-biehl has made even more changes in PR #5381. We need to still decide do we want to incorporate them, or part of them, before closing this issue. We can also close this and do more style enhancements in RF 7.4. |
Let's close this and consider more enhancements later. |
The Dialogs library in Robot Framework, which is based on Tkinter, plays a key role in creating interactive tests. However, the styling and design options are currently quite limited.
The text was updated successfully, but these errors were encountered: