Keyword arguments not used when resolving its documentation and tags … #3566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
- Coverage 74.21% 74.15% -0.05%
==========================================
Files 199 200 +1
Lines 16466 16578 +112
Branches 2653 2672 +19
==========================================
+ Hits 12218 12292 +74
- Misses 3817 3844 +27
- Partials 431 442 +11
Continue to review full report at Codecov.
|
…old failed state (python 3 does this for itself and the method does not exist)
|
I don't have time to really look at the PR now, but on a quick look it seems rather complicated. It actually seems so complicated that the functionality provided by it may not be worth the increased maintenance cost. This is especially true because in the next RF major version we plan to refactor execution side code and we most likely need to touch this code as well. |
|
Oh well - it was fun trying. I had realized it was complex, which is why I deliberately tried to contain the change to one module and reduced the complexity from where I had started. |
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
- Coverage 74.21% 74.15% -0.06%
==========================================
Files 199 200 +1
Lines 16466 16590 +124
Branches 2653 2675 +22
==========================================
+ Hits 12218 12300 +82
- Misses 3817 3847 +30
- Partials 431 443 +12
Continue to review full report at Codecov.
|
…#3238
The code has been modified to resolve the arguments before executing the keyword. This required splitting the StatusReporter context manager so that any resolution errors could be put into the reporting context.
All tests have passed except Telnet tests.
New tests have been added for tags with parameters.