#4751 reimport same lib with different arguments #4804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing cause I might have oversimplified this and not considered other scenarios where it's intentional to use the same instance... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If that's still the case or reasonable to reimport the same library with different arguments then I've made a small change that does that (too simple to believe that it's enough - maybe I'm missing something/some bigger picture of it). IMHO it should allow me to use the "latest" version of an imported library. Anyway - it turns out that the Importer object
robotframework/src/robot/running/importer.py:49returns a new instance of the same library with different arguments, but later theNamespaceobject checks if that library is imported (only vianameattribute)robotframework/src/robot/running/namespace.py:130and if the names are the same - it does nothing.If this case sounds like a bug/feature then I'd be glad if maintainers could verify this.
Thanks in advance