Skip to content

Expand Collapse for Test Execution Errors section | log.html #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kiteretsu-daihyakka
Copy link

@kiteretsu-daihyakka kiteretsu-daihyakka commented Jan 14, 2024

Collapse/Expand Errors section:
image

image

image

Idea:

  • Errors section will display errors by default in expanded mode and when the user is done reading the errors and want to focus on the steps, User can collapse the Errors section.

Benefits:

  • When long list of errors is there for a user, User can collapse the errors for time being to quickly scroll to the failed step, and can focus on the steps.
  • Existing javascript code utilized.

Explanation of changes made to files:

  • Code of function toggleElement separated one more level inside new function toggleSymbol in log.js.
  • Errors table kept inside suite element and treated as suite in log.html.
  • toggleSymbol function added in addErrors function to expand errors after the page has loaded.

@kiteretsu-daihyakka
Copy link
Author

@pekkaklarck Please review this PR as it solves the Expand collapse issue for "test execution errors" section.

@kiteretsu-daihyakka kiteretsu-daihyakka changed the title log.html | expand collapse for test-execution-errors Expand Collapse for Test Execution Errors section | log.html Nov 25, 2024
@kiteretsu-daihyakka
Copy link
Author

kiteretsu-daihyakka commented Nov 25, 2024

#4888 This issue could be resolved with above PR merge.
@pekkaklarck @Snooz82 @jussimalinen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant