generate_random_string_new_markers #5109
Open
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added markers for ARABIC and for POLISH characters.
|
This PR would need tests. |
|
It would probably be a good idea to move the marker definition to module global scope to make updating it easier. |
|
@pekkaklarck Added tests, but if there is someone who is familiar with Arabic and could take a look would appreciate that - I'm not really familiar with language. Moved the marker to map, I hope this is what you meant by module global scope, if you would like me to move it somewhere else let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added markers for ARABIC and POLISH characters.
closes #5093