Mention logging with ERROR level when using --exitonerror #5388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree it's a good idea to mention that using the ERROR log level stops execution if The added documentation looks good in general, but there are few things to be adjusted. I'll just merge this PR and do cleanup afterwards. Thanks for you contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this is not mentioned anywhere else. I scratched my head on it for a while.
It appears that the term "ERROR" is used for different purpose in TRY/EXCEPT (i.e. exception or failure) or logging (i.e. level).
Maybe it would be valuable to also mention it in the TRY/EXCEPT section :