Skip to content

reording CI and failing test #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

reording CI and failing test #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
run: pip install -r requirements.txt
- name: Run tests and collect coverage
run: pytest --cov --junitxml=junit.xml -o junit_family=legacy app
- name : Uploading test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/test-results-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
#- name : Uploading test results to Codecov
# if: ${{ !cancelled() }}
#uses: codecov/test-results-action@v1
#with:
# token: ${{ secrets.CODECOV_TOKEN }}
- name: Upload coverage to Codecov (arg token)
uses: codecov/codecov-action@main
with:
Expand All @@ -45,8 +45,8 @@ jobs:
# fail_ci_if_error: true
#use_oidc: true
#verbose: true
#- name: Upload test results to Codecov
# if: ${{ !cancelled() }}
#uses: codecov/test-results-action@v1
#with:
#token: ${{ secrets.CODECOV_TOKEN }}
- name: Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/test-results-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
2 changes: 1 addition & 1 deletion app/test_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

def test_add():
assert Calculator.add(1, 2) == 3.0
assert Calculator.add(1.0, 1.0) == 2.0
assert Calculator.add(1.0, 1.0) == 3.0
assert Calculator.add(0, 2.0) == 2.0
assert Calculator.add(2.0, 0) == 2.0
assert Calculator.add(-4, 2.0) == -2.0
Expand Down
Loading