Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql #1

SourceryAI · 2023-02-14T07:01:50Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/full-stack-fastapi-postgresql master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2023-02-14T07:01:52Z

{{cookiecutter.project_slug}}/backend/app/app/utils.py

-    with open(Path(settings.EMAIL_TEMPLATES_DIR) / "test_email.html") as f:
-        template_str = f.read()
+    template_str = Path(
+        Path(settings.EMAIL_TEMPLATES_DIR) / "test_email.html"
+    ).read_text()


Function send_test_email refactored with the following changes:

Simplify basic file reads with pathlib (path-read)

SourceryAI · 2023-02-14T07:01:52Z

{{cookiecutter.project_slug}}/backend/app/app/utils.py

-    with open(Path(settings.EMAIL_TEMPLATES_DIR) / "reset_password.html") as f:
-        template_str = f.read()
+    template_str = Path(
+        Path(settings.EMAIL_TEMPLATES_DIR) / "reset_password.html"
+    ).read_text()


Function send_reset_password_email refactored with the following changes:

Simplify basic file reads with pathlib (path-read)

SourceryAI · 2023-02-14T07:01:52Z

{{cookiecutter.project_slug}}/backend/app/app/utils.py

-    with open(Path(settings.EMAIL_TEMPLATES_DIR) / "new_account.html") as f:
-        template_str = f.read()
+    template_str = Path(
+        Path(settings.EMAIL_TEMPLATES_DIR) / "new_account.html"
+    ).read_text()


Function send_new_account_email refactored with the following changes:

Simplify basic file reads with pathlib (path-read)

SourceryAI · 2023-02-14T07:01:52Z

{{cookiecutter.project_slug}}/backend/app/app/utils.py

-    encoded_jwt = jwt.encode(
-        {"exp": exp, "nbf": now, "sub": email}, settings.SECRET_KEY, algorithm="HS256",
+    return jwt.encode(
+        {"exp": exp, "nbf": now, "sub": email},
+        settings.SECRET_KEY,
+        algorithm="HS256",
    )
-    return encoded_jwt


Function generate_password_reset_token refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2023-02-14T07:01:53Z

{{cookiecutter.project_slug}}/backend/app/app/api/deps.py

-    user = crud.user.get(db, id=token_data.sub)
-    if not user:
+    if user := crud.user.get(db, id=token_data.sub):
+        return user
+    else:
        raise HTTPException(status_code=404, detail="User not found")
-    return user


Function get_current_user refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Lift code into else after jump in control flow (reintroduce-else)

Swap if/else branches (swap-if-else-branches)

SourceryAI · 2023-02-14T07:01:54Z

{{cookiecutter.project_slug}}/backend/app/app/core/security.py

-    encoded_jwt = jwt.encode(to_encode, settings.SECRET_KEY, algorithm=ALGORITHM)
-    return encoded_jwt
+    return jwt.encode(to_encode, settings.SECRET_KEY, algorithm=ALGORITHM)


Function create_access_token refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2023-02-14T07:01:54Z

{{cookiecutter.project_slug}}/backend/app/app/crud/crud_user.py

-        user = self.get_by_email(db, email=email)
-        if not user:
-            return None
-        if not verify_password(password, user.hashed_password):
+        if user := self.get_by_email(db, email=email):
+            return user if verify_password(password, user.hashed_password) else None
+        else:
            return None
-        return user


Function CRUDUser.authenticate refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Lift code into else after jump in control flow [×2] (reintroduce-else)

Swap if/else branches (swap-if-else-branches)

Replace if statement with if expression (assign-if-exp)

Swap if/else branches of if expression to remove negation (swap-if-expression)

SourceryAI · 2023-02-14T07:01:55Z

{{cookiecutter.project_slug}}/backend/app/app/tests/utils/user.py

-    headers = {"Authorization": f"Bearer {auth_token}"}
-    return headers
+    return {"Authorization": f"Bearer {auth_token}"}


Function user_authentication_headers refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2023-02-14T07:01:55Z

{{cookiecutter.project_slug}}/backend/app/app/tests/utils/user.py

-    user = crud.user.get_by_email(db, email=email)
-    if not user:
-        user_in_create = UserCreate(username=email, email=email, password=password)
-        user = crud.user.create(db, obj_in=user_in_create)
-    else:
+    if user := crud.user.get_by_email(db, email=email):
        user_in_update = UserUpdate(password=password)
        user = crud.user.update(db, db_obj=user, obj_in=user_in_update)

+    else:
+        user_in_create = UserCreate(username=email, email=email, password=password)
+        user = crud.user.create(db, obj_in=user_in_create)


Function authentication_token_from_email refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Swap if/else branches (swap-if-else-branches)

SourceryAI · 2023-02-14T07:01:55Z

{{cookiecutter.project_slug}}/backend/app/app/tests/utils/utils.py

-    headers = {"Authorization": f"Bearer {a_token}"}
-    return headers
+    return {"Authorization": f"Bearer {a_token}"}


Function get_superuser_token_headers refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

'Refactored by Sourcery'

c357172

SourceryAI commented Feb 14, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql #1

Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql #1

Uh oh!

SourceryAI commented Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

SourceryAI Feb 14, 2023

Uh oh!

Uh oh!

Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql #1

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql #1

Uh oh!

Conversation

SourceryAI commented Feb 14, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!