fix (rrdom): Fix edge case where oldChild can become detach causing the recursive function to end early #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function to end early
🦋 Changeset detectedLatest commit: f428458 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pauldambra
reviewed
Aug 1, 2025
| const newNode = createOrGetNode(newChild, replayer.mirror, rrnodeMirror); | ||
|
|
||
| try { | ||
| handleInsertBefore(oldTree, newNode, oldChild); |
There was a problem hiding this comment.
may be a silly question... where is handleInsertBefore defined?
i don't find it in rrweb at all
There was a problem hiding this comment.
Yes, maybe this PR is incomplete? @arivyiii is that a mispelling or something that was left out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case in diffChildren: when we replace an old child via oldTree.parentNode?.replaceChild(calibratedOldTree, oldTree); its nextSibling pointer is lost, causing the diff loop to exit early and inadvertently remove subsequent elements and styles.