Skip to content

Create SECURITY.md #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 5, 2025
Merged

Create SECURITY.md #1719

merged 8 commits into from
Aug 5, 2025

Conversation

rotemreiss
Copy link
Contributor

At the moment, there's no documentation on how to report security vulnerabilities to rrweb-io on the rrewb project.
Please review my suggestion, make edits if needed, and provide security researchers a responsible way to report security vulnerabilities in this widely used project.

Copy link

changeset-bot bot commented Jul 28, 2025

⚠️ No Changeset found

Latest commit: f17d810

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email route worries me that it becomes an unmonitored black box
and i'm not keen on saying "immediately" when the maintainers might be volunteering their time
but otherwise, this helps with clarity

SECURITY.md Outdated
## Reporting a Vulnerability

Please do not report security vulnerabilities through public GitHub issues.
Instead, please report them to our GitHub Security page. If you prefer to submit one without using GitHub, you can also email us at security@rrweb.io.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Juice10 would that email route anywhere?
i'd guess it's better not to have an email route published since then someone needs to monitor that inbox

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've set up a new private google group for this which will also email members of the core team directly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauldambra, @eoghanmurray - Thanks for merging it!
Could you also consider enabling the vulnerability report feature to allow private vulnerability reports directly via GitHub?

This is where you can find this config:
image

YunFeng0817 and others added 6 commits August 5, 2025 00:55
Co-authored-by: Paul D'Ambra <paul.dambra@gmail.com>
mention the google group is private
@YunFeng0817 YunFeng0817 merged commit 0bceef6 into rrweb-io:master Aug 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants