Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rsmpi/rsmpi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: mpi-0.7.0
Choose a base ref
...
head repository: rsmpi/rsmpi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mpi-0.8.0
Choose a head ref
  • 20 commits
  • 36 files changed
  • 4 contributors

Commits on Oct 21, 2023

  1. Merge pull request #170 from rsmpi/jed/release-0.7

    release 0.7
    jedbrown authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    faaea11 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Allow using dynamic reference to communicator (#157)

    * fix #148
    
    * add example for dynamic communicator
    
    * changed generic functions for group parameters in CommunicatorHandle to use trait-objects to make them object-safe
    
    * changed compare function in communicator traits to work with trait-objects
    
    * sealed CommunicatorHandle enum to hide it from public API
    
    * added sealed trait AsHandle to obtain comm handles from communicators
    
    * use CommunicatorHandle in process instead of generic communicator.
     - changed constructors for Process type
     - changed AnyProcess analogous
     - implemented Communicator for Process, such that AsCommunicator can be implemented without violating borrow checker
     - changed functions in Communicator trait that return processes to be object-safe
    
    * extracted sealed module into separate file
    
    * remove obsolete syntax
    Cydhra authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d03d7f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Refactor attributes and add support for setting

    Attributes now hide the keys from most user code, and are easy to
    implement for new types. We place set_attr and get_attr in a new trait
    with blanket implementation to support object safety with &dyn
    Communicator.
    jedbrown committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    72589bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7cec5f9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #171 from rsmpi/jed/attr-refactor

    Refactor attributes and add support for setting
    jedbrown authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4216521 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. cargo msrv and docs (#173)

    * MSRV: add Cargo.lock and cargo update in CI
    
    We frequently have CI failures because transitive dependencies have
    releases that require new MSRV. The Rust project now suggests committing
    Cargo.lock for reproducibility and to enable testing MSRV.
    
    https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
    https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
    https://doc.rust-lang.org/cargo/guide/continuous-integration.html#verifying-latest-dependencies
    
    Perhaps this can be removed if this Pre-RFC is implemented.
    
    https://internals.rust-lang.org/t/pre-rfc-msrv-aware-resolver/19871
    
    * doc: scrape examples on docs.rs
    
    * ci: allow oversubscription for Open-MPI 5.x
    jedbrown authored Dec 25, 2023
    Configuration menu
    Copy the full SHA
    ee61f64 View commit details
    Browse the repository at this point in the history
  2. docs: fix homepage example indentation (#172)

    * docs: fix homepage example indentation
    
    * docs: add ci linting of code comments in nightly
    
    * cargo fmt code in doc comments
    
    ---------
    
    Co-authored-by: Jed Brown <jed@jedbrown.org>
    HoloTheDrunk and jedbrown authored Dec 25, 2023
    Configuration menu
    Copy the full SHA
    7ece090 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Fix process.as_communicator().rank() and examples/structured

    * Bug/confusion introduced here: https://github.com/rsmpi/rsmpi/pull/157/files#r1462677040
    * Process now holds AnyProcess and returns reference to it in as_communicator()
    * Fix denied warning in examples/structured.rs and make more strict
    * AnyProcess is now Copy and Clone, like Process
    * Add Process::is_self() for common pattern
    jedbrown committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8857a29 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #177 from rsmpi/jed/fix-process-structured

    Fix process.as_communicator().rank() and examples/structured
    jedbrown authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0d8a529 View commit details
    Browse the repository at this point in the history
  3. Bump shlex from 1.2.0 to 1.3.0 (#175)

    Bumps [shlex](https://github.com/comex/rust-shlex) from 1.2.0 to 1.3.0.
    - [Changelog](https://github.com/comex/rust-shlex/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/comex/rust-shlex/commits)
    
    ---
    updated-dependencies:
    - dependency-name: shlex
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    98d3a8b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Linting for edition=2021

    jedbrown committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9401647 View commit details
    Browse the repository at this point in the history
  2. cargo upgrade

    jedbrown committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f5e9256 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #180 from rsmpi/jed/linting

    Linting for edition=2021 and cargo upgrade
    jedbrown authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    309eb7b View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. doc: improve docs for ready send

    * Quote from the standard about erroneous use of ready send.
    
    * Add loud warning in `examples/immediate.rs` where ready send is
    used (sending to self) since it appears people have copied this example
    into uses in which ready send is invalid.
    
    Arguably, ready send should become unsafe because it's so risky to use
    and unlikely to be caught by the MPI implementation's run-time checking.
    I.e., detection of misuse will be non-deterministic and can easily be
    very unlikely in practice.
    jedbrown committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1e5eeab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87c58f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c29c91f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. make ready send unsafe (fix #182)

    Ready-mode sends requirements are difficult to ensure without heavy
    synchronization (that would outweight the possible performance gains).
    The ordering semantics are subject to race conditions and usually not
    detectable by the implementation, thus erroneous use may not produce an
    MPI error as would be possible for a quality implementation of most
    other MPI routines.
    jedbrown committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0316f5f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #184 from rsmpi/ready-mode-unsafe

    Ready mode is unsafe
    jedbrown authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    46b049c View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. CHANGELOG fix

    jedbrown committed May 3, 2024
    Configuration menu
    Copy the full SHA
    15fbb3c View commit details
    Browse the repository at this point in the history
  2. chore: Release

    jedbrown committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b2ca71d View commit details
    Browse the repository at this point in the history
Loading