Fix CSV.filter to preserve headers #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Sep 11, 2020
lib/csv.rb
Outdated
| @@ -1058,9 +1058,11 @@ def filter(input=nil, output=nil, **options) | |||
| end | |||
| end | |||
| # build input and output wrappers | |||
| input = new(input || ARGF, **in_options) | |||
| input = parse(input || ARGF, **in_options) | |||
There was a problem hiding this comment.
We should not use parse here because parse parses all input at once. It may consume large resource.
|
|
||
| if input.instance_of?(CSV::Table) | ||
| output << input.headers | ||
| end |
There was a problem hiding this comment.
This adds headers twice with the following case:
def test_filter_with_headers
input = <<-CSV
foo,0
bar,1
baz,2
CSV
output = ""
CSV.filter(input, output, headers: ["Name", "Value"], output_write_headers: true) do |row|
row
end
assert_equal(input, output)
end| baz,2 | ||
| CSV | ||
| output = "" | ||
| CSV.filter(input, output, headers: true, write_headers: true) do |row| |
There was a problem hiding this comment.
We should use output_write_headers: here. If we use write_headers:, input is also rewritten.
|
OK, thanks. I don't have a proper fix for this, but I do think it's a bug, and I think the test I've included is valid. Do you have a good fix for this? |
|
OK. I take over this. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.