Skip to content

Doesn't work seeking position when set input class of StringIO #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2019
Merged

Doesn't work seeking position when set input class of StringIO #98

merged 8 commits into from
Aug 20, 2019

Conversation

katsyoshi
Copy link
Contributor

@katsyoshi katsyoshi commented Aug 13, 2019 •
edited
Loading

Doesn't work seeking position when set input class of StringIO.

I add position for StringIOs.

example: https://gist.github.com/katsyoshi/bfd86639d9464f60f27b26e20a85c720

@esparta
Copy link
Contributor

esparta commented Aug 14, 2019

I'm seeing the failure on your gist, can you add a test case for this StringIO input?

kou
kou requested changes Aug 14, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Could you use input.read instead of input.string[input.pos..-1]? Because input.string[..] is character based not byte based. It means that this implementation doesn't work for multibyte characters.

Could you add a test for this case? Or should I add a test for this?

@kou kou mentioned this pull request Aug 15, 2019
Closed
@katsyoshi
Copy link
Contributor Author

@kou @esparta thank you comments.
I replaced string range chars to read. I added test using StringIO.

@kou
Copy link
Member

kou commented Aug 20, 2019

Thanks. I've fixed some remaining problems:

  • We don't need to use rewind when we use seek.
  • There are some needless rewinds.
  • The added test doesn't use StringIO. We need to use StringIO for this case.

@kou kou merged commit ccf47e3 into ruby:master Aug 20, 2019
@kou kou mentioned this pull request Sep 12, 2019
Closed
@MarcPer MarcPer mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katsyoshi @esparta @kou