Skip to content

Remove needless SUDO_PASSWORD for git.ruby-lang.org #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Remove needless SUDO_PASSWORD for git.ruby-lang.org #61

merged 1 commit into from
Oct 20, 2022

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 20, 2022

@k0kubun git.ruby-lang.org used shared admin user and this user can use sudo with NOPASSWD. Can we remove SUDO_PASSWORD check now?

k0kubun
k0kubun approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Even better.

@hsbt hsbt merged commit b38a288 into master Oct 20, 2022
@hsbt hsbt deleted the remove-sudo branch October 20, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @k0kubun