Favor decimal notation over scientific notation for floats #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, thanks for taking care of it. |
|
Interestingly, JRuby always has been using scientific notation for this. |
e.g. ``` JSON.dump(1746861937.7842371) ``` master: ``` "1.7468619377842371e+9" ``` This branch and older json versions: ``` 1746861937.7842371 ``` In the end it's shorter, and according to `canada.json` benchmark performance is the same.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 26, 2025
…ge negative floats. Fix: ruby/json#807 Since ruby/json#800, `fpconv_dtoa` can actually generate up to 28 chars. ruby/json@d73ae93d3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
master:
This branch and older json versions:
In the end it's shorter, and according to
canada.jsonbenchmark performance is the same.@radiospiel any objections?
For reference, sidekiq was using a bad regexp to parse JSON and was broken by this change: sidekiq/sidekiq#6700. I'm not considering using scientific notation to workaround that bug, but I think it's better overall.