Skip to content

♻️ Update versioned default configs (backports #412) #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Feb 26, 2025

This backports #412 to v0.4-stable, which should make it easier to cherry-pick other backported config changes to stable branches (with fewer merge conflicts).

This reorganizes the creation of `Config.version_defaults` to make it
easier to cherry-pick backported config changes to stable branches:
* Sets `Config[0.4]` as a diff from the previous versioned default, just
  like the other versioned defaults.
* Sets `Config[:current] = Config[VERSION.to_f]`, so it will not need to
  be updated for any x.y.0 release.  Likewise, sets `Config[:next]` to
  `Config[VERSION.to_f + 0.1]` which only rarely needs to be changed.
* Because `Config[:default]` and `Config[:current]` are now derived two
  different ways, both a warning and a test have been added to ensure
  they remain synchronized.
* A few other `Config.version_defaults` tests were added or updated.
@nevans nevans added the backport This issue or PR is for a stable release branch label Feb 26, 2025
@nevans nevans changed the title ♻️ Update versioned default configs ♻️ Update versioned default configs (backports #412) Feb 26, 2025
@nevans nevans merged commit dce128b into v0.4-stable Feb 26, 2025
30 checks passed
@nevans nevans deleted the backport-to-0.4-config-reorder-version-defaults branch February 26, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This issue or PR is for a stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant