♻️ Rational config versions #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Rational internally, with aliases for Float and Integer versions. Fixes #428.
889043c to
d0e4af7
Compare
This enables more flexible lookups. So we can now use something like `Config["0.4.11"]` (I do _not_ intend to store version defaults for `x.y.z` releases). I had to add a special-case for zero, to avoid `Config["missing"] == Config[0r]`
d0e4af7 to
c7732e6
Compare
nevans
added a commit
that referenced
this pull request
Apr 18, 2025
…ig-version ♻️ Rational config version (backport #429 to v0.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Config.version_defaultsto useRationalinternally, with aliases forFloat.Adds a
default_proctoConfig.version_defaultsto enable more flexible lookups. For example, we can now use something likeConfig["0.4.11"](I do not intend to store version defaults forx.y.zreleases). I had to add a special-case for zero, to avoidConfig["missing"] == Config[0r]Fixes #428.