Skip to content

♻️ Generate same stringprep tables with ruby 3.4 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented May 1, 2025

Ruby 3.4 changed its Hash#inspect representation (for the better). So, every time I run rake (after switching to a branch that updates mtimes on related files), this file is converted to the ruby 3.4+ format.

This commit normalizes the output. It uses the older format simply to keep the diff small. Next time we update the stringprep code, we can switch to the ruby 3.4+ format.

Ruby 3.4 changed its `Hash#inspect` representation (for the better).
So, every time I run rake (after switching to a branch that updates
mtimes on related files), this file is converted to the ruby 3.4+
format.

This commit normalizes the output.  It uses the older format simply to
keep the diff small.  Next time we update the stringprep code, we can
switch to the ruby 3.4+ format.
@nevans nevans merged commit 6038c31 into master May 1, 2025
37 checks passed
@nevans nevans deleted the stringprep-tables-ruby-3.4 branch May 1, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant