⏪ Revert Ractor sharability for config types (v0.4 only) #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was just one piece of making config objects ractor sharable—it is insufficient by itself. And it caused problems with earlier versions of ruby 3.0. It should not have been committed to the v0.4-stable branch. Fixes: #471 Reported-by: @glaszig Reported-by: @mumkymikey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was just one piece of making config objects ractor sharable—it is insufficient by itself. And it caused problems with earlier versions of ruby 3.0. It should not have been committed to the v0.4-stable branch.
Fixes #471.
Reported by @glaszig and @mumkymikey.