Skip to content

Fix & Deprecate REXML::Text#text_indent #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 15, 2025
Merged

Fix & Deprecate REXML::Text#text_indent #275

merged 9 commits into from
Jul 15, 2025

Conversation

pboling
Copy link
Contributor

@pboling pboling commented Jul 9, 2025 •
edited
Loading

Replaces #274

@pboling pboling changed the title Bug/273 deprecate text indent text.2 Fix & Deprecate text_indent Jul 9, 2025
@pboling pboling changed the title Fix & Deprecate text_indent Fix & Deprecate REXML::Text#text_indent Jul 9, 2025
kou
kou reviewed Jul 14, 2025
View reviewed changes
pboling and others added 2 commits July 14, 2025 17:18
@pboling @kou
Update test/test_text.rb
3939083 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pboling @kou
Update text.rb
586b745 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
kou
kou reviewed Jul 14, 2025
View reviewed changes
pboling added a commit to pboling/rexml that referenced this pull request Jul 14, 2025
@pboling
🐛 Add helper, feedback from @kou
e5815f5 
- ruby#275 (comment)
@pboling pboling force-pushed the bug/273-deprecate-text-indent_text.2 branch from e5815f5 to e125605 Compare July 14, 2025 21:29
kou
kou reviewed Jul 14, 2025
View reviewed changes
kou
kou reviewed Jul 14, 2025
View reviewed changes
pboling and others added 2 commits July 15, 2025 07:52
@pboling @kou
Update xpath.rb
90c640e 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pboling @kou
Update text.rb
0573544 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@kou kou merged commit 9b084d7 into ruby:master Jul 15, 2025
65 of 67 checks passed
@kou
Copy link
Member

kou commented Jul 15, 2025

Thanks.

@pboling pboling deleted the bug/273-deprecate-text-indent_text.2 branch July 16, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REXML::Text#indent_text broken since v3.2.6
2 participants
@pboling @kou