Skip to content

Switch {prism: true} to {parser: :prism} in ISeq.to_a #10112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

kddnewton
Copy link
Contributor

A follow-up to #9934 (comment).

@ko1 could you review? Sorry for missing the comment the first time!

Copy link

launchable-app bot commented Feb 27, 2024

Launchable Report

❌ Test session #2659815 failedos:ubuntu-20.04 test_opts:cppflags:-DVM_CHECK_MODE test_task:check
🔔 no issues ✖️1 test failed ✔️24768 tests passed

❌ Test session #2659820 failedos:ubuntu-20.04 test_opts: test_task:check
🔔 no issues ✖️1 test failed ✔️23794 tests passed

❌ Test session #2665078 failedos:macos-arm-oss test_opts:--repeat-count:2 test_task:test-all
🔔 no issues ✖️6 tests failed ✔️49466 tests passed

Passed test sessions

✅ Test session #2659807 passed os:macos-arm-oss test_opts: test_task:check
✅ Test session #2659811 passed os:ubuntu-20.04 test_opts:--enable-shared--enable-load-relative test_task:check
✅ Test session #2659812 passed os:ubuntu-20.04 test_opts:--disable-yjit test_task:check
✅ Test session #2659813 passed os:macos-12 test_opts: test_task:check
✅ Test session #2659816 passed os:macos-13 test_opts: test_task:check

Build: refs_pull_10112_merge_4ebd1f9da8a6ce9dfe524dc95999aed423dca068

@kddnewton
Copy link
Contributor Author

cc @mame also tagging you just because you reviewed the other one

@kddnewton kddnewton merged commit 742abbf into ruby:master Feb 28, 2024
@kddnewton kddnewton deleted the iseq-toa branch February 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants