Freeze singleton class chain #10245
Freeze singleton class chain #10245
Conversation
The following code: ```ruby x = Object.new sc1 = x.singleton_class sc2 = sc1.singleton_class x.freeze ``` Would freeze sc1 but not sc2, even though sc1 would be frozen. Not freezing the entire singleton class chain is expected, because at a certain point, the singleton class is shared. However, you can walk the the attached object chain for each singleton class, and only freeze if it results in the original object. This way, only non-shared singleton classes are frozen. Fixes [Bug #20319]
f4f8f51 to
ff2b943
Compare
Right, by "shared singleton class" that's actually only internal CRuby state, i.e., before the singleton class of that class has been needed (e.g. by calling I think it this is a good way to fix the inconsistency shown in https://bugs.ruby-lang.org/issues/20319 |
The following code:
Would freeze sc1 but not sc2, even though sc1 would be frozen.
Not freezing the entire singleton class chain is expected, because at a certain point, the singleton class is shared. However, you can walk the the attached object chain for each singleton class, and only freeze if it results in the original object. This way, only non-shared singleton classes are frozen.
Fixes [Bug #20319]