-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Namespace on read #10247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tagomoris
wants to merge
44
commits into
ruby:master
Choose a base branch
from
tagomoris:namespace-on-read-snapshot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Namespace on read #10247
+5,820
−678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
035dc71
to
6855945
Compare
Launchable Report❌ Test session #2727464 failed Passed test sessions✅ Test session #2727456 passed Build: refs_pull_10247_merge_68559456760b3870f4ff3bfc4e34d56806aa8c4f |
Try on Playground: https://ruby.github.io/play-ruby?run=8313778912 |
6855945
to
035dc71
Compare
035dc71
to
245b961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/19744
Features
autoload
end
of class/module definitionsclass/module
in namespaces on built-in classes/modulesNothing to do
TODOs
basename
in C instead of callingrb_funcall
inrb_namespace_local_extension
Namespace
to containrb_namespace_t
directly instead of havingNamespace::Entry
refiner
module lazily to not make overhead if monkey patches are not donerequire
in methods defined in namespace on non-namespaced threadsremove_const
,const_defined
,const_added
,rb_define_global_const
, etc