.github/workflows/windows.yml - fix use of vcpkg.json #11005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ed2684 to
0881297
Compare
The vcpkg.json file must exist before `vcpkg install` is run
0881297 to
7994a34
Compare
|
Currently the windows.yml workflow has a 'Install libraries with vcpkg' step. This can be verbose. Added a 'List vcpkg libraries' step that logs the library packages and their versions. There is a concern that library package upgrades may cause CI failures, and placing the info in a separate step makes it easy to compare package versions. |
|
Closing in favor of #11014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vcpkg.jsonfile must exist beforevcpkg installis run, and the command must run in the file's directory.EDIT: Sorry for the force push (double CI runs).
vcpkg installwill not upgrade packages, andvcpkg upgradewill not upgrade packages that are not installed.Since users working in a fork may not have vcpkg cache files, so the packages need to be installed. A repo with caches may need some or all of the packages to be upgraded if
vcpkg.jsonis updated with a more recent commit SHA. Hence, both commands are needed...