Skip to content

Integrate Launchable into make btest #11113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Jul 6, 2024

Recently, Launchable has been used for analyzing flaky tests. Like #11043, Kokubun-san asked me to integrate Launchable into make btest for analyzing flay tests in make btest, so I've created this PR to address it.

RJIT is a good place as a first step for make btest since RJIT is flaky now.

@ono-max ono-max force-pushed the support-make-test branch 5 times, most recently from 64c6b6f to c993500 Compare July 7, 2024 10:08
@ono-max ono-max force-pushed the support-make-test branch from c993500 to 1241fb5 Compare July 7, 2024 10:10
@ono-max ono-max marked this pull request as ready for review July 7, 2024 10:58
@hsbt
Copy link
Member

hsbt commented Jul 8, 2024

I suggest to move tool/lib/test/unit/launchable.rb to tool/lib/launchable.rb same as envutil.rb, leakchecker.rb.

We should move them to under the tool/lib/test. But it has side effect for LOAD_PATH of the default gems.

@hsbt hsbt enabled auto-merge (rebase) July 8, 2024 01:10
@hsbt hsbt merged commit 8ede84a into ruby:master Jul 8, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants