lib/bundled_gems.rb: more reliable caller detection #11322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `2` skipped frames went out of sync and now it should be `3`. Rather than just update the offset, we can implement a way that is adaptative as long as all require decorators are also called require. Also we should compute the corresponding `uplevel` otherwise the warning will still point decorators.
mattbrictson
reviewed
Aug 7, 2024
There was a problem hiding this comment.
I confirmed on my machine that this PR fixes the problem I reported in #10351, but I am not sure if the solution is working entirely as intended; see comment below.
| @@ -168,7 +194,7 @@ def self.build_message(gem) | |||
| end | |||
| end | |||
| if caller_gem | |||
| msg += " Also contact author of #{caller_gem} to add #{gem} into its gemspec." | |||
| msg += "\nAlso please contact the author of #{caller_gem} to request adding #{gem} into its gemspec." | |||
There was a problem hiding this comment.
For some reason, when using this branch I am not seeing the "please contact the author" message when I run the reproduction script from #10351 (comment).
$ ruby -v
ruby 3.4.0dev (2024-08-07T09:05:43Z improve-bundled-gems e4e2ab05f0) [x86_64-darwin23]
$ ruby bundled.rb
/Users/mbrictson/.rbenv/versions/ruby-dev/lib/ruby/gems/3.4.0+0/gems/childprocess-5.0.0/lib/childprocess.rb:7: warning: /Users/mbrictson/.rbenv/versions/ruby-dev/lib/ruby/3.4.0+0/logger.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
$
matzbot
pushed a commit
that referenced
this pull request
Aug 8, 2024
|
@casperisfine Thanks. I merged this at 7594a29 and 7e0910a. I update you patch with Ruby 3.3 support because I want to backport |
|
Thank you @hsbt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
2skipped frames went out of sync and now it should be3.Rather than just update the offset, we can implement a way that is adaptative as long as all require decorators are also called require.
Also we should compute the corresponding
uplevelotherwise the warning will still point decorators.Using the script reported at: #10351 (comment)
I also improved the message slightly:
I'd really like to add a test for this, but I really don't see how I could...
@mattbrictson @hsbt