Run annocheck for libruby.so #11324
Merged
Run annocheck for libruby.so #11324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164a5fd to
14143c3
Compare
nobu
reviewed
Aug 7, 2024
14143c3 to
d535ae6
Compare
junaruga
commented
Aug 7, 2024
d535ae6 to
10d8db1
Compare
When building with the `--shared` option, most functionality is kept in `libruby.so`. Therefore also run annocheck for `libruby.so`. Use `ARG IN_DIR` to propagate multiple files into the container instead of `ARG FILES` in the `Dockerfile-copy`. Because the `COPY` syntax in Dockerfile doesn't support copying the multiple files. https://stackoverflow.com/questions/61599384/specify-multiple-files-in-arg-to-copy-in-dockerfile Co-authored-by: Vít Ondruch <vondruch@redhat.com>
10d8db1 to
41bbbfd
Compare
|
I confirmed that the test-annocheck passed, checking the https://github.com/ruby/ruby/actions/runs/10285685378/job/28464546087?pr=11324#step:10:100 |
|
Just FTR, I would love to see if this was resolved: Because that actually means Ruby is not properly hardened. But that has separate tracker: |
|
I added the prefix "CI: " to the commit message and title on this PR, changing it from the original PR. However, I realized that it was wrong. Because this PR improving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rework for the #11123. I tested in my forked repository, and confirmed the test-annocheck case passing properly testing both
rubyandlibruby.so. Below is the CI log.https://github.com/junaruga/ruby/actions/runs/10284090286/job/28459376922#step:10:106
When building with the
--sharedoption, most functionality is kept inlibruby.so. Therefore also run annocheck forlibruby.so.Use
ARG IN_DIRto propagate multiple files into the container instead ofARG FILESin theDockerfile-copy. Because theCOPYsyntax in Dockerfile doesn't support copying the multiple files.https://stackoverflow.com/questions/61599384/specify-multiple-files-in-arg-to-copy-in-dockerfile
Co-authored-by: Vít Ondruch vondruch@redhat.com