Enable native SOCKS support by default [Feature #20673] #11441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80e9305 to
154cc72
Compare
Before: Enable SOCKS support when `configure` with `--enable-socks` or `make` with `SOCKS_SERVER` environment variable. After: Enable SOCKS support when `configure` without `--disable-socks`. Both: Enabling SOCKS support needs socks library when `make`. (socks5, socksd, or socks)
154cc72 to
7972fa3
Compare
|
From https://bugs.ruby-lang.org/issues/20673 We would like to extract |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Enable SOCKS support when
configurewith--enable-socksormakewithSOCKS_SERVERenvironment variable.After:
Enable SOCKS support when
configurewithout--disable-socks.Both:
Enabling SOCKS support needs socks library when
make. (socks5, socksd, or socks)