Fix function name #11515
Closed
Fix function name #11515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an EVP_aes_128_cbc() function in openssl, but no EVP_EVP_aes_128_cbc(). To trigger this, you need an OpenSSL library compiled without DES/3DES support, or various other obsolescent crypto.
|
Please report it to the upstream, https://github.com/ruby/openssl. |
|
While this patch is a correct fix, I think removing these lines would be a better idea considering that it has never worked since initially written in 2003. As @nobu says, https://github.com/ruby/openssl is the upstream for files in ext/openssl. I'm closing this PR here. |
infracaninophile
added a commit
to infracaninophile/openssl
that referenced
this pull request
Sep 7, 2024
There is no such function as `EVP_EVP_aes_128_cbc()` in openssl. This should read `EVP_aes_128_cbc()` In order to see a compilation failure due to this, it is necessary to build a version of openssl without any of the older and less secure ciphers, including omitting DES/3DES. Previously submitted as ruby/ruby#11515 -- resubmitting here as requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an EVP_aes_128_cbc() function in openssl, but no EVP_EVP_aes_128_cbc().
To trigger this, you need an OpenSSL library compiled without DES/3DES support, or various other obsolescent crypto.