Improve bundled gem warning messages #12669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
389b232 to
c59e936
Compare
|
@hsbt I have some more improvements that I'd like to build on top of this. Can you have a look when you get a moment? |
If anything, I think this may be causing some false positives.
Most of the stuff is not actually necessary.
The name "gem" could be confused with RubyGems activation method.
Currently evenn if the require actually fails, they suggest that the file was actually loaded, which is confusing. I reworded them to reduce this confusion.
c59e936 to
ff61489
Compare
|
@deivid-rodriguez Thanks! This change simplified the current complex logic. I'll merge this because the spec is passed now. If we have unexpected cases, I will fix that until next stable release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information about default gems no longer available at
requiretime is currently a bit confusing once the default gem is no longer available.This is because it suggests that the missing gem was actually loaded, and that the problem is a warning, not an actual error.
This PR improves the wording from something like
to something like
While looking into this improvement, I realized that the current implementation was much more complicated than it needed to, so I removed a bunch of code.